Fix/NPE panic on tree services connection close #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog, please. |
Codecov Report
@@ Coverage Diff @@
## master #2335 +/- ##
=======================================
Coverage 30.00% 30.00%
=======================================
Files 400 400
Lines 30160 30160
=======================================
Hits 9048 9048
Misses 20373 20373
Partials 739 739
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Error can appear during new connection establishing and the `nil` connection is stored in LRU cache. Not try to close such connections. Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
notimetoname
force-pushed
the
fix/tree-svc-panic
branch
from
d26d502
to
52392c6
Compare
roman-khimov
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error can appear during new connection establishing and the
nilconnection is stored in LRU cache. Not try to close such connections.