-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upd/Generics have landed #2340
Upd/Generics have landed #2340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
+ Coverage 29.87% 29.88% +0.01%
==========================================
Files 398 398
Lines 29825 29806 -19
==========================================
- Hits 8909 8907 -2
+ Misses 20199 20182 -17
Partials 717 717
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4f2afba
to
43ee249
Compare
43ee249
to
b808b2e
Compare
#2342 is done. Lets have generic fun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I'm impressed with the diffstat though (+137 −159
), my expectations were somewhat higher. Something tells me we'll need to revise these caches anyway.
Please add #2181 fix/close somewhere.
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
@roman-khimov, added to PR's description. It is 8 commits now, not sure which of them should have that link (or all?).
In fact, mine was too. But i like that we do not have casts (ok, "assertions") in that code anymore, i find that parentheses dance (4+ in one expression) hard to read. Also, i would say that generics just do their work, and if it can be done with a small amount of code it should be done. In other words, i would say that our caches are too complex, so generics do not make them shorter where nothing relates to "generic code". Anyway, i think, LRU caches will be updated to |
b808b2e
to
3cdec55
Compare
Closes #2181. Blocked by #2342.