Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/EndpointInfo serving #2568

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented Sep 11, 2023

Be a flexible storage node: take the updated by the Alphabet NodeInfo as the
source of truth and bootstrap with it (if this info is available and SN does not
bootstrap for the first time).

@carpawell carpawell self-assigned this Sep 11, 2023
@carpawell carpawell force-pushed the fix/SN-uses-different-states-for-bootstrap-and-EndpointInfo-RPC branch 2 times, most recently from 044519e to 6db25b8 Compare September 11, 2023 18:35
Be a flexible storage node: take the updated by the Alphabet `NodeInfo` as the
source of truth and bootstrap with it (if this info is available and SN does not
bootstrap for the first time).

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the fix/SN-uses-different-states-for-bootstrap-and-EndpointInfo-RPC branch from 6db25b8 to 9a04642 Compare September 11, 2023 18:37
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2568 (e725855) into master (2a44054) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head e725855 differs from pull request most recent head 9a04642. Consider uploading reports for the commit 9a04642 to get more accurate results

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
- Coverage   29.82%   29.81%   -0.02%     
==========================================
  Files         405      405              
  Lines       30881    30885       +4     
==========================================
- Hits         9210     9208       -2     
- Misses      20880    20885       +5     
- Partials      791      792       +1     
Files Changed Coverage Δ
cmd/neofs-node/config.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just proves that IR shouldn't mess with endpoint data.

@roman-khimov roman-khimov merged commit eb141a0 into nspcc-dev:master Sep 11, 2023
7 of 8 checks passed
@carpawell carpawell deleted the fix/SN-uses-different-states-for-bootstrap-and-EndpointInfo-RPC branch September 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants