Make adm compatible with new contracts #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2662 +/- ##
==========================================
- Coverage 30.43% 30.40% -0.03%
==========================================
Files 406 406
Lines 30068 30095 +27
==========================================
Hits 9150 9150
- Misses 20134 20161 +27
Partials 784 784 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
requested changes
Dec 1, 2023
"register" doesn't work for TLDs since 0.18.0. Signed-off-by: Roman Khimov <roman@nspcc.ru>
With current adm it's the easiest way to ensure domains are present when we're deploying contracts. Additional NNS parameters are ignored by old contracts, but used in 0.18.0+ versions. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Old (pre-0.18.0) versions will just ignore this, but newer ones will deploy the TLD we need. Signed-off-by: Roman Khimov <roman@nspcc.ru>
* netmap must be deployed first, balance and container depend on it * they also call it during deployment and need an appropriate witness * we can't send independent deployment transactions in this scenario * but our contract set fits into a single transaction, luckily Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
make-adm-compatible-with-new-contracts
branch
from
4bcb84c
to
4e22e02
Compare
cthulhu-rider
approved these changes
Dec 1, 2023
carpawell
approved these changes
Dec 1, 2023
| @@ -290,6 +290,20 @@ func (c *initializeContext) getSigner(fancyScope bool, acc *wallet.Account) tran | |||
| } | |||
|
|
|||
| signer = morphClient.GetUniversalSignerScope(nnsHash, balanceHash, cntHash, netmapHash, neofsIDHash) | |||
| // Deploy-only rules. | |||
There was a problem hiding this comment.
But why? They're never needed during regular operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.