client: Accept context parameter in Dial
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Oct 3, 2022
cthulhu-rider
commented
- based on and blocked by rpc/client: Use dial timeout properly neofs-api-go#419
- closes Use context during client dial #343
cthulhu-rider
requested review from
fyrchik,
carpawell,
acid-ant and
alexvanin
cthulhu-rider
force-pushed
the
bugfix/343-client-dial-context
branch
from
f33ed86
to
e4fa564
Compare
In previous implementation of `Client.Dial` there was no ability to specify parent context (e.g. global application context). Add `PrmDial.SetContext` method which accepts optional base dial context. Use the context to open client connection or fall back to using `context.Background()`. Upgraded version of `github.com/nspcc-dev/neofs-api-go/v2` module also fixes the problem when dial timeout didn't work properly. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
After recent changes `client.Client` accepts dial context. There is a need to forward the context passed into `Pool.Dial` to the underlying `Client` instances. Define type aliases of different client constructors: context-based and non-context. Use context-based constructor in `Pool`. Pass `ctx` parameter of `Pool.Dial` method to the client builder. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
force-pushed
the
bugfix/343-client-dial-context
branch
from
e4fa564
to
c3398dc
Compare
fyrchik
reviewed
Oct 5, 2022
| @@ -100,7 +106,13 @@ func (c *Client) Dial(prm PrmDial) error { | |||
| c.setNeoFSAPIServer((*coreServer)(&c.c)) | |||
|
|
|||
| // TODO: (neofs-api-go#382) perform generic dial stage of the client.Client | |||
| _, _ = rpc.Balance(&c.c, new(v2accounting.BalanceRequest)) | |||
| _, err := rpc.Balance(&c.c, new(v2accounting.BalanceRequest), | |||
| client.WithContext(prm.parentCtx), | |||
There was a problem hiding this comment.
context.Background() is used.
acid-ant
approved these changes
Oct 6, 2022
alexvanin
approved these changes
Oct 7, 2022
carpawell
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.