Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqadmin has hardcoded templates path #113

Closed
angry-elf opened this issue Dec 24, 2012 · 3 comments
Closed

nsqadmin has hardcoded templates path #113

angry-elf opened this issue Dec 24, 2012 · 3 comments
Labels

Comments

@angry-elf
Copy link

May be, it may be calculated at compile time?

How to reproduce:

Change PREFIX in Makefile to something other than /usr/local (example - /usr)

# make
...
# make install
...
# nsqadmin
2012/12/24 12:27:57 nsqadmin v0.2.16-alpha
2012/12/24 12:27:57 --template-dir must be specified (or install the templates to /usr/local/share/nsqadmin/templates)

What expected - nsqadmin to use templates from /usr/share/nsqadmin/templates directory

@mreiferson
Copy link
Member

It does have hardcoded default paths, however we added a command line paramater to nsqadmin called --template-dir so that you could specify an alternative directory at runtime.

we chose not to overly complicate the makefile and have it modify code before compiling, although admittedly it could do that (perhaps via code generation, or search/replace, etc.).

@angry-elf
Copy link
Author

May be, in future versions, with generic config-file.

Ok, I understand the situation. Who supposed to close such issues? Issuer or team?

@mreiferson
Copy link
Member

I'll close, thanks @angry-elf

absolute8511 added a commit to absolute8511/nsq that referenced this issue Jan 12, 2023
Optimize and adjust glog error  behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants