-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsqd: config file support #279
Conversation
dare I say https://github.com/mojombo/toml? |
https://github.com/BurntSushi/toml seems to be the cleanest and most robust Go implementation |
RFR @jehiah |
according to travis it looks like https://github.com/BurntSushi/toml only supports |
never mind, got it all working on all versions of Go... had to make some changes to how we handle travis + cc @jehiah |
looks good overall.. some questions/thoughts
|
|
assuming travis is happy this is RFR @jehiah |
💯 this is some of the worlds cleanest config handling. |
yea, I think one day I'll pull the guts (the option resolution) out into a separate package... I think it's generally useful |
Prep 1.0.8 release; drop dep support
consider first-class support for providing flags and options via config files.
I favor the format & behavior used by git, which allows for subsections dedicated to different components (and referencing those via dot notation.)
e.g.: