test refactoring #434
Merged
test refactoring #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mreiferson
commented
Aug 7, 2014
mreiferson
commented
- pluggable daemon logging
- remove assert dependency
- redirect all test logs through t.Log
- don't run tests with -v
- fix test conn flakiness nsqd: flakey TestStats #432 and nsqd: flakey TestClientAttributes #414
This was referenced Aug 7, 2014
Closed
this ensures that the connections are referenced until the end of each test function execution, to prevent a pre-emptive GC from cleaning up and closing a connection underneath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.