run flake8 on Travis-CI, make flake8 clean #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
flake8_clean
branch
2 times, most recently
from
c69b591
to
0ec0d25
Compare
jehiah
approved these changes
Jul 9, 2018
ploxiln
commented
Jul 9, 2018
| return x | ||
| return [cast(x) for x in v.replace('-', '.').split('.')] | ||
|
|
||
| if self.disabled.__code__ != Reader.disabled.__code__ and \ | ||
| semver(data['version']) >= semver('0.3'): | ||
| logging.warning('disabled() deprecated and incompatible with nsqd >= 0.3. ' + | ||
| 'It will be removed in a future release. Use set_max_in_flight(0) instead') |
There was a problem hiding this comment.
Fixed the long line here by just removing this logging.warning(), while leaving the warnings.warn() just below. I figure pre-1.0 stuff will be removed pretty soon anyway.
also update flake8 config
|
rebased on top of the python3.7 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be happy to make stylistic changes to the bits I had to tweak to avoid warnings.