Render more content, inlined

[rgbkrk]

I've combined our overall Contents rendering into one component.

• Cleanup the styling
  • Full width and height for inlined iframe, not bound by container
• Figure out how we'll serve relative assets (images should load after all)
  • Create the /view/ and /files endpoints
  • Redirect /view/ on non-html, non-notebook to /files/.
• iframe HTML content

[cabhishek]

related to #43

[rgbkrk]

I'm definitely not having the best developer experience when trying to hack on the express server (not the UI components). It seems like new routes aren't being mapped properly.

[cabhishek]

@rgbkrk is it express stuff or the way commuter server structure is laid out?

[rgbkrk]

Mostly the way the commuter server structure is laid out I think. #80 is related here, since running them together is easy to get started yet hard to iterate on either the server or the react app.

[rgbkrk]

Aside from the DX, here's what I'm trying to do (some of which is done):

• /view/ - provides a view to a file; I'm explicitly handling it this way so that random HTML gets rendered into an iframe
• /files/ - serve file contents directly, not for use by users explicitly; this is where for example /view/image.png would get redirected to /files/image.png.

[rgbkrk]

Alright, back on this with some renewed perspectives after trying out next. Likely going to eject from react scripts to control the proxy more programmatically.

[rgbkrk]

This is working quite well now, all the way to rendering relative assets. However, in dev mode relative assets won't work -- they need to be able to hit the /view/ to /files/ redirect, which won't work with create-react-app for now.

[rgbkrk]

I'll get tests fixed up next.

[rgbkrk]

Preview:

^^ relative image shown