Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix underscore issue #84

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Fix underscore issue #84

merged 5 commits into from
Feb 11, 2021

Conversation

rohitsanj
Copy link
Member

Fixes #82

Used get_ipython().last_execution_result.result to get last execution result instead of _ (underscore).

Reference StackOverflow answer

@rohitsanj rohitsanj requested a review from MSeal February 10, 2021 14:10
@rohitsanj rohitsanj mentioned this pull request Feb 10, 2021
Closed
MSeal
MSeal approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that exploration led to a clean solution

@MSeal MSeal merged commit febcf08 into master Feb 11, 2021
@rohitsanj rohitsanj deleted the rs/fix-underscore-inject-issue branch February 11, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail if there's _ (underscore) defined in the notebook
2 participants
@rohitsanj @MSeal