Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide logos as "easter eggs" #52

Merged
merged 1 commit into from
Feb 8, 2018
Merged

provide logos as "easter eggs" #52

merged 1 commit into from
Feb 8, 2018

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Feb 8, 2018

This includes the nteract and jupyter logos.

* nteract (purple)
* jupyter
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute!

@mpacer
Copy link
Member

mpacer commented Feb 8, 2018

This is cute! I can't think of how to test something like this though…

Copy link
Member

@mpacer mpacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice easter_egg, the only part that I hesitate around is continuing to grow our flat namespace instead of having a subpackage for svg.

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 8, 2018

Seems like a nice easter_egg, the only part that I hesitate around is continuing to grow our flat namespace instead of having a subpackage for svg.

svg is in vdom.svg though, what do you mean?

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 8, 2018

This is cute! I can't think of how to test something like this though…

😄 I suppose the best we can do at the moment is something similar to jest snapshots, we import and use both components, verify that the json structure still matches the last known copy. Are there good ways to do that with pytest?

@rgbkrk rgbkrk merged commit f662efe into nteract:master Feb 8, 2018
@rgbkrk rgbkrk deleted the logos branch February 8, 2018 23:49
@mpacer
Copy link
Member

mpacer commented Feb 9, 2018

I meant

vdom 
⋮
|- svg
    |- __init__.py (where current svg functionality lives)
    |- logos.py (where the logos would live)

But it's not as important until we have another case where something would make sense as a submodule of svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants