Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "async fn" for Service::ready() and Service::shutdown() methods #361

Merged
merged 3 commits into from
May 28, 2024

Conversation

fafhrd91
Copy link
Member

No description provided.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 81.69399% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 90.39%. Comparing base (d8f55de) to head (bb093e4).

Files Patch % Lines
ntex-service/src/pipeline.rs 80.31% 25 Missing ⚠️
ntex-service/src/boxed.rs 0.00% 17 Missing ⚠️
ntex-service/src/util.rs 77.41% 14 Missing ⚠️
ntex-service/src/lib.rs 27.27% 8 Missing ⚠️
ntex-service/src/map_config.rs 0.00% 2 Missing ⚠️
ntex-service/src/macros.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   90.87%   90.39%   -0.49%     
==========================================
  Files         197      198       +1     
  Lines       31754    31918     +164     
==========================================
- Hits        28858    28851       -7     
- Misses       2896     3067     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 force-pushed the async-ready branch 6 times, most recently from d57c39e to a9f8e62 Compare May 28, 2024 09:40
@fafhrd91 fafhrd91 merged commit dec6ab0 into master May 28, 2024
20 of 22 checks passed
@fafhrd91 fafhrd91 deleted the async-ready branch May 28, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant