-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Package Name to @ntohq/buefy-next
For Publishing to NPM
#13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesdevpro I have reviewed the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesdevpro I have reviewed the changes. Let's see what happens.
Sounds good! We also need to approve PR #12 after this one is pulled into |
* fix(lib): b-field-body wrapped text in b-field - Fixes the bug that a horizontal `b-field-body` wrapped a simple text element with an extra `b-field`. It now returns a text element as is. issue #5 * fix(lib): performance warning on FieldBody - Removes a Vue runtime warning that indicated a potential performance issue related to how `FieldBody` gave the default slot to `Field`. Changes the third parameter of `h` function call to create a `Field` from a direct child `[element]` to a function slot `() => element`. This will address the issue pointed at in the comment: #1 (comment) * fix(lib): remove unexpected tabindex (#9) - Fixes the bug that `Table` ended up with `<table>` with an unexpected "tabindex" attribute. This bug was caused because Vue 3 no longer removes a boolean attribute if its value is "false". `Table` binds `undefined` instead of `false` to "tabindex" if `focusable` is `false` or not specified. issue #8 * Publish Package @ntohq/buefy-next (#10) * Removed CircleCi * Created GitHub Action Workflow Files * Added Workflow and Updated Package.json * Update package.json (#11) * Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13) * Update package.json * Rename Package For Publishing to NPM * Rename Package For Publishing to NPM * Cleaned Up Workflow and Package.json * Update package.json --------- Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
* fix(lib): b-field-body wrapped text in b-field - Fixes the bug that a horizontal `b-field-body` wrapped a simple text element with an extra `b-field`. It now returns a text element as is. issue #5 * fix(lib): performance warning on FieldBody - Removes a Vue runtime warning that indicated a potential performance issue related to how `FieldBody` gave the default slot to `Field`. Changes the third parameter of `h` function call to create a `Field` from a direct child `[element]` to a function slot `() => element`. This will address the issue pointed at in the comment: #1 (comment) * fix(lib): remove unexpected tabindex (#9) - Fixes the bug that `Table` ended up with `<table>` with an unexpected "tabindex" attribute. This bug was caused because Vue 3 no longer removes a boolean attribute if its value is "false". `Table` binds `undefined` instead of `false` to "tabindex" if `focusable` is `false` or not specified. issue #8 * Publish Package @ntohq/buefy-next (#10) * Removed CircleCi * Created GitHub Action Workflow Files * Added Workflow and Updated Package.json * Update package.json (#11) * Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13) * Update package.json * Rename Package For Publishing to NPM * Rename Package For Publishing to NPM * Cleaned Up Workflow and Package.json * Update package.json * Renamed Workflow Folder --------- Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
* fix(lib): b-field-body wrapped text in b-field - Fixes the bug that a horizontal `b-field-body` wrapped a simple text element with an extra `b-field`. It now returns a text element as is. issue #5 * fix(lib): performance warning on FieldBody - Removes a Vue runtime warning that indicated a potential performance issue related to how `FieldBody` gave the default slot to `Field`. Changes the third parameter of `h` function call to create a `Field` from a direct child `[element]` to a function slot `() => element`. This will address the issue pointed at in the comment: #1 (comment) * fix(lib): remove unexpected tabindex (#9) - Fixes the bug that `Table` ended up with `<table>` with an unexpected "tabindex" attribute. This bug was caused because Vue 3 no longer removes a boolean attribute if its value is "false". `Table` binds `undefined` instead of `false` to "tabindex" if `focusable` is `false` or not specified. issue #8 * Publish Package @ntohq/buefy-next (#10) * Removed CircleCi * Created GitHub Action Workflow Files * Added Workflow and Updated Package.json * Update package.json (#11) * Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13) * Update package.json * Rename Package For Publishing to NPM * Rename Package For Publishing to NPM * Cleaned Up Workflow and Package.json * Update package.json * Renamed Workflow Folder * Update npm_deploy.yml --------- Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
* fix(lib): b-field-body wrapped text in b-field - Fixes the bug that a horizontal `b-field-body` wrapped a simple text element with an extra `b-field`. It now returns a text element as is. issue #5 * fix(lib): performance warning on FieldBody - Removes a Vue runtime warning that indicated a potential performance issue related to how `FieldBody` gave the default slot to `Field`. Changes the third parameter of `h` function call to create a `Field` from a direct child `[element]` to a function slot `() => element`. This will address the issue pointed at in the comment: #1 (comment) * fix(lib): remove unexpected tabindex (#9) - Fixes the bug that `Table` ended up with `<table>` with an unexpected "tabindex" attribute. This bug was caused because Vue 3 no longer removes a boolean attribute if its value is "false". `Table` binds `undefined` instead of `false` to "tabindex" if `focusable` is `false` or not specified. issue #8 * Publish Package @ntohq/buefy-next (#10) * Removed CircleCi * Created GitHub Action Workflow Files * Added Workflow and Updated Package.json * Update package.json (#11) * Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13) * Update package.json * Rename Package For Publishing to NPM * Rename Package For Publishing to NPM * Cleaned Up Workflow and Package.json * Update package.json * Renamed Workflow Folder * Update npm_deploy.yml * fix(lib): empty BMenuList crash (#21) - Fixes the bug where an empty `BMenuList` crashed with "TypeError: slots.default is not a function". I found `slots.default` was `undefined` if `BMenuList` was empty. `BMenuList` makes sure `slots.default` is a function before calling it, otherwise returns `slots.default` as is. issue #20 * fix(lib): empty FieldBody crash (#22) - Fixes the bug where `FieldBody` crashed if no default slot was given. `FieldBody` makes sure that `this.$slots.default` is a function before calling it and not null before accesssing its fields. This is a potential cause of #18, but there might be other reasons. issue #18 * chore: bump version to 0.1.1 --------- Co-authored-by: Wesley Ford <wes@wesdev.pro>
No description provided.