Fix BMenuList crash with "TypeError: slots.default is not a function" #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the bug where an empty `BMenuList` crashed with "TypeError: slots.default is not a function". I found `slots.default` was `undefined` if `BMenuList` was empty. `BMenuList` makes sure `slots.default` is a function before calling it, otherwise returns `slots.default` as is. issue ntohq#20
wesdevpro
pushed a commit
that referenced
this pull request
Aug 9, 2023
* fix(lib): b-field-body wrapped text in b-field - Fixes the bug that a horizontal `b-field-body` wrapped a simple text element with an extra `b-field`. It now returns a text element as is. issue #5 * fix(lib): performance warning on FieldBody - Removes a Vue runtime warning that indicated a potential performance issue related to how `FieldBody` gave the default slot to `Field`. Changes the third parameter of `h` function call to create a `Field` from a direct child `[element]` to a function slot `() => element`. This will address the issue pointed at in the comment: #1 (comment) * fix(lib): remove unexpected tabindex (#9) - Fixes the bug that `Table` ended up with `<table>` with an unexpected "tabindex" attribute. This bug was caused because Vue 3 no longer removes a boolean attribute if its value is "false". `Table` binds `undefined` instead of `false` to "tabindex" if `focusable` is `false` or not specified. issue #8 * Publish Package @ntohq/buefy-next (#10) * Removed CircleCi * Created GitHub Action Workflow Files * Added Workflow and Updated Package.json * Update package.json (#11) * Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13) * Update package.json * Rename Package For Publishing to NPM * Rename Package For Publishing to NPM * Cleaned Up Workflow and Package.json * Update package.json * Renamed Workflow Folder * Update npm_deploy.yml * fix(lib): empty BMenuList crash (#21) - Fixes the bug where an empty `BMenuList` crashed with "TypeError: slots.default is not a function". I found `slots.default` was `undefined` if `BMenuList` was empty. `BMenuList` makes sure `slots.default` is a function before calling it, otherwise returns `slots.default` as is. issue #20 * fix(lib): empty FieldBody crash (#22) - Fixes the bug where `FieldBody` crashed if no default slot was given. `FieldBody` makes sure that `this.$slots.default` is a function before calling it and not null before accesssing its fields. This is a potential cause of #18, but there might be other reasons. issue #18 * chore: bump version to 0.1.1 --------- Co-authored-by: Wesley Ford <wes@wesdev.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
slots.defaultis a function before calling it