Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Package @ntohq/buefy-next #10

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Publish Package @ntohq/buefy-next #10

merged 3 commits into from
Jul 24, 2023

Conversation

wesdevpro
Copy link

No description provided.

@wesdevpro wesdevpro self-assigned this Jul 22, 2023
@wesdevpro wesdevpro added enhancement New feature or request help wanted Extra attention is needed labels Jul 22, 2023
@wesdevpro wesdevpro mentioned this pull request Jul 22, 2023
Closed
@kikuomax
Copy link
Collaborator

@wesdevpro
If I correctly understand the configurations around npm publish, the package will be published as buefy-next. In my opinion, it makes more sense if the packaged is scoped in @ntohq, i.e., as @ntohq/buefy-next, considering the transient nature of the package. I mean the package will be only relevant until we release official Buefy for Vue 3.

@kikuomax
Copy link
Collaborator

If I correctly understand the configurations around npm publish, the package will be published as buefy-next. In my opinion, it makes more sense if the packaged is scoped in @ntohq, i.e., as @ntohq/buefy-next, considering the transient nature of the package. I mean the package will be only relevant until we release official Buefy for Vue 3.

@wesdevpro Sorry, I overlooked the title of the PR. You actually intend to publish it as @ntohq/buefy-next.

@kikuomax
Copy link
Collaborator

@wesdevpro
How about to replace urls in repository and bugs fields with https://github.com/ntohq/buefy-next and https://github.com/ntohq/buefy-next/issues respectively?

buefy-next/package.json

Lines 25 to 31 in 67ecf3a

"repository": {
"type": "git",
"url": "https://github.com/buefy/buefy.git"
},
"bugs": {
"url": "https://github.com/buefy/buefy/issues"
},

@wesdevpro
Copy link
Author

wesdevpro commented Jul 24, 2023 •
edited
Loading

@wesdevpro How about to replace urls in repository and bugs fields with https://github.com/ntohq/buefy-next and https://github.com/ntohq/buefy-next/issues respectively?

buefy-next/package.json

Lines 25 to 31 in 67ecf3a

"repository": {
"type": "git",
"url": "https://github.com/buefy/buefy.git"
},
"bugs": {
"url": "https://github.com/buefy/buefy/issues"
},

I will make these change in a different PR.

@wesdevpro wesdevpro merged commit f0187a2 into dev Jul 24, 2023
@wesdevpro wesdevpro deleted the GitHubWorkflows branch July 24, 2023 21:02
wesdevpro pushed a commit that referenced this pull request Jul 25, 2023
@kikuomax
Update main from dev And Publish @ntohq/buefy-next to NPM (#12)
a3c3ec5 
* fix(lib): b-field-body wrapped text in b-field

- Fixes the bug that a horizontal `b-field-body` wrapped a simple text
  element with an extra `b-field`. It now returns a text element as is.

issue #5

* fix(lib): performance warning on FieldBody

- Removes a Vue runtime warning that indicated a potential performance
  issue related to how `FieldBody` gave the default slot to `Field`.
  Changes the third parameter of `h` function call to create a `Field`
  from a direct child `[element]` to a function slot `() => element`.

  This will address the issue pointed at in the comment:
  #1 (comment)

* fix(lib): remove unexpected tabindex (#9)

- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue #8

* Publish Package @ntohq/buefy-next (#10)

* Removed CircleCi

* Created GitHub Action Workflow Files

* Added Workflow and Updated Package.json

* Update package.json (#11)

* Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13)

* Update package.json

* Rename Package For Publishing to NPM

* Rename Package For Publishing to NPM

* Cleaned Up Workflow and Package.json

* Update package.json

---------

Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
wesdevpro pushed a commit that referenced this pull request Jul 25, 2023
@kikuomax
Rename Workflow Folder to Workflows (#14)
3f4bc81 
* fix(lib): b-field-body wrapped text in b-field

- Fixes the bug that a horizontal `b-field-body` wrapped a simple text
  element with an extra `b-field`. It now returns a text element as is.

issue #5

* fix(lib): performance warning on FieldBody

- Removes a Vue runtime warning that indicated a potential performance
  issue related to how `FieldBody` gave the default slot to `Field`.
  Changes the third parameter of `h` function call to create a `Field`
  from a direct child `[element]` to a function slot `() => element`.

  This will address the issue pointed at in the comment:
  #1 (comment)

* fix(lib): remove unexpected tabindex (#9)

- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue #8

* Publish Package @ntohq/buefy-next (#10)

* Removed CircleCi

* Created GitHub Action Workflow Files

* Added Workflow and Updated Package.json

* Update package.json (#11)

* Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13)

* Update package.json

* Rename Package For Publishing to NPM

* Rename Package For Publishing to NPM

* Cleaned Up Workflow and Package.json

* Update package.json

* Renamed Workflow Folder

---------

Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
wesdevpro pushed a commit that referenced this pull request Jul 25, 2023
@kikuomax
Add NPM Public Access Flag to Publish Workflow (#15)
f0348bf 
* fix(lib): b-field-body wrapped text in b-field

- Fixes the bug that a horizontal `b-field-body` wrapped a simple text
  element with an extra `b-field`. It now returns a text element as is.

issue #5

* fix(lib): performance warning on FieldBody

- Removes a Vue runtime warning that indicated a potential performance
  issue related to how `FieldBody` gave the default slot to `Field`.
  Changes the third parameter of `h` function call to create a `Field`
  from a direct child `[element]` to a function slot `() => element`.

  This will address the issue pointed at in the comment:
  #1 (comment)

* fix(lib): remove unexpected tabindex (#9)

- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue #8

* Publish Package @ntohq/buefy-next (#10)

* Removed CircleCi

* Created GitHub Action Workflow Files

* Added Workflow and Updated Package.json

* Update package.json (#11)

* Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13)

* Update package.json

* Rename Package For Publishing to NPM

* Rename Package For Publishing to NPM

* Cleaned Up Workflow and Package.json

* Update package.json

* Renamed Workflow Folder

* Update npm_deploy.yml

---------

Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
wesdevpro pushed a commit that referenced this pull request Aug 9, 2023
@kikuomax
Fix "TypeError: this.$slots.default is not a function" (#18, #20) (#25)
0d04c8f 
* fix(lib): b-field-body wrapped text in b-field

- Fixes the bug that a horizontal `b-field-body` wrapped a simple text
  element with an extra `b-field`. It now returns a text element as is.

issue #5

* fix(lib): performance warning on FieldBody

- Removes a Vue runtime warning that indicated a potential performance
  issue related to how `FieldBody` gave the default slot to `Field`.
  Changes the third parameter of `h` function call to create a `Field`
  from a direct child `[element]` to a function slot `() => element`.

  This will address the issue pointed at in the comment:
  #1 (comment)

* fix(lib): remove unexpected tabindex (#9)

- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue #8

* Publish Package @ntohq/buefy-next (#10)

* Removed CircleCi

* Created GitHub Action Workflow Files

* Added Workflow and Updated Package.json

* Update package.json (#11)

* Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (#13)

* Update package.json

* Rename Package For Publishing to NPM

* Rename Package For Publishing to NPM

* Cleaned Up Workflow and Package.json

* Update package.json

* Renamed Workflow Folder

* Update npm_deploy.yml

* fix(lib): empty BMenuList crash (#21)

- Fixes the bug where an empty `BMenuList` crashed with "TypeError:
  slots.default is not a function". I found `slots.default` was
  `undefined` if `BMenuList` was empty. `BMenuList` makes sure
  `slots.default` is a function before calling it, otherwise returns
  `slots.default` as is.

issue #20

* fix(lib): empty FieldBody crash (#22)

- Fixes the bug where `FieldBody` crashed if no default slot was given.
  `FieldBody` makes sure that `this.$slots.default` is a function before
  calling it and not null before accesssing its fields. This is a
  potential cause of #18, but there might be other
  reasons.

issue #18

* chore: bump version to 0.1.1

---------

Co-authored-by: Wesley Ford <wes@wesdev.pro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dword-design dword-design dword-design approved these changes

@kikuomax kikuomax Awaiting requested review from kikuomax

Assignees

@wesdevpro wesdevpro

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesdevpro @kikuomax @dword-design