input key size dependant AES key -hashes and -sizes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2019
Closed
emanuele-f
suggested changes
Jun 2, 2019
|
Thank you for your feedback. Will go through it, maybe somewhen during the weekend and "update" the pull request. |
|
I have restored Maybe that would be worth a new issue discussion... |
|
The "Resolve Conflicts" button just produces a never-ending-wheeling copy cat... any hint on how to resolve the indicated conflict (which should already be resolved in code)? |
|
Mmmmh , still conflicting... "Resolve Conflicts" not working... I am lost. Will try to make a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies the scheme of #101 to generate internal key material and key sizes from the input key.
As a by-product,
TRANSOP_AES_IV_SEED_SIZEnow can range between 0 and 16 allowing the compiler savvy user to determine the trade-off between highest security (=16 byte random IV seed, longer packet) and (=0 byte random IV seed to be transmitted, shorter packet). Default is the well discussed and balanced value of 8.These changes break compatibility to current dev version as key material now is generated in a different way than before, all edges would need to be updated.