Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in ndpi_utils.c "Attemot" #2415

Closed
netcons opened this issue May 3, 2024 · 4 comments
Closed

Typo in ndpi_utils.c "Attemot" #2415

netcons opened this issue May 3, 2024 · 4 comments
Labels

Comments

@netcons
Copy link

netcons commented May 3, 2024

grep Attemot ./src/lib/ndpi_utils.c
    return("Binary Data Transfer Attemot");
@netcons netcons added the bug label May 3, 2024
@IvanNardi
Copy link
Collaborator

@netcons, are you going to push a fix yourself?

@netcons
Copy link
Author

netcons commented May 3, 2024

Wasn't sure if you wanted a pull request for one character, should I go ahead ?

@IvanNardi
Copy link
Collaborator

yes, please! If you are able, please update also the unit tests results (make + NDPI_FORCE_UPDATING_UTESTS_RESULTS=1 ./tests/do.sh) Otherwise, I'll update them myself

@netcons
Copy link
Author

netcons commented May 4, 2024

Apologies, seems this was replaced in: Tuned DNS risk values - commit bd2968d

@netcons netcons closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants