Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default CIDR to /32 #8362

Closed
lucaderi opened this issue Apr 27, 2024 · 1 comment
Closed

Set the default CIDR to /32 #8362

lucaderi opened this issue Apr 27, 2024 · 1 comment
Assignees
@NicoMaio
Labels
Low-Priority Bug Ready to Test a feedback is needed on a proposal or implementation

Comments

@lucaderi
Copy link
Member

Currently, this form has two issues
image

  • the default CIDR is not set (it should be /32 for IPv4 and /128 for IPv6)
  • when not all fields are configured the Add button is turned off without being clear about what fields are missing as in the example picture /24 seems to be filled in but it is not
NicoMaio added a commit that referenced this issue May 2, 2024
@NicoMaio
Fix default CIDR and add an invalid class to handle missing fields in…
847f07f 
… the modal. (#8362)
NicoMaio added a commit that referenced this issue May 2, 2024
@NicoMaio
Update dist (#8362)
73334cc
@NicoMaio NicoMaio added Ready to Test a feedback is needed on a proposal or implementation and removed In Progress labels May 2, 2024
@lucaderi
Copy link
Member Author

lucaderi commented May 2, 2024

Verified as fixed

@lucaderi lucaderi closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicoMaio NicoMaio

Labels
Low-Priority Bug Ready to Test a feedback is needed on a proposal or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucaderi @NicoMaio