Fixes for #100 (stall of transmit logic) and #102 (packet corruption) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntruchsess
changed the title
Workaround for errata12 using timeout
|
Are you still planing to merge this request, or do you need more testing to be sure? |
|
While it seems to work It still needs a bit of refactoring as it implements a retransmit-logic that is useful for UDP packets but unnecessary for TCP (as TCP will retransmit lost packages anyway). Simplifying this part should result in smaller footprint. Unfortunately I'm quite busy these days - hope to have time for this issue during winter-holidays. If you feel you might contribute please go ahead :-) |
|
Well, this version is running rock solid for quite some time now on my projects, I think you nailed the problem. Thanks for all your effort Norbert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #100 and #102
(unfortunally these fixes come with a penalty of 116 bytes flash though...)