Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer error handling #14

Merged
merged 1 commit into from
Aug 30, 2012
Merged

Finer error handling #14

merged 1 commit into from
Aug 30, 2012

Conversation

rjarry
Copy link
Contributor

@rjarry rjarry commented Aug 29, 2012

Hello mate,

I hope summer was good :-)

I'm putting my head back in the code and I though that finer error handling would be cool for your lib.

Also I added a basic setup.py file so you can publish the module in pypi and allow people to get it with easy_install (and also put it as a dependency in their projects). If you're not convinced this is a good idea, I'd like to discuss this with you :)

Fly safe o/

Robin AKA diabeteman

@ntt
Copy link
Owner

ntt commented Aug 29, 2012

Not a bad idea :). I'm not going to keep the same names for those errors though.

I'll prolly go with these:
RequestError (having "bad" in there would be redundant)
AuthenticationError (since the reason isn't always a bad apikey)
ServerError (just seems a bit more "pro")

@rjarry
Copy link
Contributor Author

rjarry commented Aug 30, 2012

Yup your names do sound better. ^^

How about the setup.py script and this whole pypi stuff ?

@ntt
Copy link
Owner

ntt commented Aug 30, 2012

suppose it can't hurt. I'll have a looksie later.

@rjarry
Copy link
Contributor Author

rjarry commented Aug 30, 2012

Ok tell me if you need some help on this. Pypi is kind of weird, it took me a while to get a grip on it.

If you want to be able to register & upload packages from the command line without all the fuzz on their website (which I recommend). You will need to add a ~/.pypirc file with this content

[pypi]
username=<username>
password=<password>

Then when you have a new version of your package, do this :

./setup.py clean sdist register upload

And you're done :)

ntt added a commit that referenced this pull request Aug 30, 2012
Finer error handling + setup file.
@ntt ntt merged commit ab3e35e into ntt:master Aug 30, 2012
@ntt
Copy link
Owner

ntt commented Aug 30, 2012

some person ninja'd the evapi name on pypi though so ill have to poke him/her first to remove it >.<

@rjarry
Copy link
Contributor Author

rjarry commented Aug 30, 2012

Yes I saw that yesterday :x I hope the guy is not dead nor willing to keep it.

You can always change the package name to ntt-eveapi (it doesn't have to be the same as the python module name)

@ntt
Copy link
Owner

ntt commented Aug 30, 2012

I'm picky when it comes to names ;-)

@rjarry
Copy link
Contributor Author

rjarry commented Aug 30, 2012

heheh i've noticed that :D

@ntt
Copy link
Owner

ntt commented Aug 30, 2012

ok, it's up. The other person removed it right away when I asked :)

@rjarry
Copy link
Contributor Author

rjarry commented Aug 30, 2012

Weeeeeee \o/

We're the first ones officially depending on you :)

http://eve-corp-management.org/projects/ecm/repository/revisions/a9def27d76b4

@kriberg
Copy link

kriberg commented Aug 31, 2012

Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants