Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct of TLVs and interface of Capabilities #41

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

Motok1
Copy link
Contributor

@Motok1 Motok1 commented Feb 11, 2023

function

refactor

  • Add struct of TLVs and interface of TLV
    • Decode and serialize appropriately for each TLV type

Copy link
Member

@watal watal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks good.
I just made one comment.

@@ -22,6 +21,24 @@ const (
RFC_COMPLIANT
)

// Determine PCC type from capability
func DetectPccType(caps []CapabilityInterface) (pccType PccType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall the function name be "DeterminePccType" to match the process description and comments?

@watal watal merged commit e08c6c3 into main Feb 12, 2023
@watal watal deleted the feature/PCEP_capability branch February 12, 2023 15:30
@Motok1 Motok1 self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants