サービス横断ステータス画面からのチケット詳細表示のモック作成 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshim03
approved these changes
Jul 26, 2024
Comment on lines
+42
to
+44
| const targetServices = pteam.services | ||
| .filter((service) => serviceIds.includes(service.service_id)) | ||
| .sort((a, b) => a.service_name.localeCompare(b.service_name)); |
There was a problem hiding this comment.
props として渡された serviceIds に含まれるserviceをソート
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
経緯・意図・意思決定
開発チーム追記
※将来的にサービスの情報を持たせる予定