Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalability, resolution, aspect ratio, and fullscreen mode in shipping build #24

Merged
merged 15 commits into from
Aug 25, 2023

Conversation

nucleartide
Copy link
Owner

@nucleartide nucleartide commented Aug 24, 2023

User Story

Basically, a bunch of changes (within Blueprints) so that the game appears as a not-pixelated, fullscreen game.

  • Set screen resolution to that of desktop resolution
  • Set fullscreen mode to fullscreen
  • Add debug helpers for stat unit and stat unitgraph, in addition to stat fps
  • Undo RenderingSettings changes in .ini file configuration
  • Set the default scalability level to "Low"
  • Set camera aspect ratio dynamically from desktop resolution

Note that this file contains several Blueprints changes:

Screenshot 2023-08-25 at 2 06 00 AM Screenshot 2023-08-25 at 2 06 13 AM Screenshot 2023-08-25 at 2 07 04 AM

Playable build

https://drive.google.com/file/d/1vPvwuIkZp6kRFaf6bupXHkPaHVWfhxfR/view?usp=drive_link

Dev checklist

  • First draft. Implement a working first pass at the feature. If it helps, try thinking about data (model), presentation (view), and logic (controller).
    • Design by contract. Write pre-condition, post-condition, and invariant assertions to catch bugs before playtesting.
    • Unit tests. If needed, write unit tests to tease out edge cases.
    • First playtest. Thoroughly playtest until you are confident that the feature (and existing features) work. This also exercises the code paths with contracts.
  • Final draft. Perform a general review of Files changed and revise anything that needs to be cleaned up.
    • Run unit tests.
    • Final playtest. After the changes above, playtest through the game one last time to ensure that everything works.
  • Fill out the pull request template. Self-explanatory.
  • Remember the GIFs. Include a recording of what's going on!
  • Update readme. Maintain a list of pull requests for easy access later.
  • Merge. Merge into master.

Release checklist

  • Build. Cut a new build in Unreal. If the game doesn't build, fix until it does.
  • Tag. Once built, tag the latest commit on master with the latest version string.
  • Upload. Upload build to Google Drive.
  • Link. Add link to this pull request.
  • Priorities. Prioritize items on work board.
  • Next task. Tee up a pull request for the next feature.

@nucleartide nucleartide changed the title Fix resolution in shipping build Fix resolution, aspect ratio, and fullscreen mode in shipping build Aug 25, 2023
@nucleartide nucleartide changed the title Fix resolution, aspect ratio, and fullscreen mode in shipping build Fix scalability, resolution, aspect ratio, and fullscreen mode in shipping build Aug 25, 2023
@nucleartide nucleartide marked this pull request as ready for review August 25, 2023 06:28
@nucleartide nucleartide merged commit df2c64b into master Aug 25, 2023
@nucleartide nucleartide deleted the jason/fix-resolution branch August 25, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant