Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates logging tags, transform float/int to use relative min/max #1798

Merged
merged 9 commits into from
Apr 20, 2024

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Apr 20, 2024

  • Updates code to not leak urls that are invalid on parse in logs
  • Updates transform_float and transform_int to use relative min/max like they were intended to
  • Adds new logging interceptor to add user information to the logs so that we can better track users in the system during debugging
  • Updates the standard logging interceptor to attach the procedure to every request to more easily track logs per procedure type.

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 11:33pm
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 11:33pm

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 64.10256% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 17.69%. Comparing base (c9ef2f9) to head (9787789).
Report is 1 commits behind head on main.

Files Patch % Lines
...l/connect/interceptors/auth_logging/interceptor.go 82.35% 6 Missing ⚠️
...ternal/connect/interceptors/logging/interceptor.go 60.00% 6 Missing ⚠️
backend/pkg/sqlconnect/sql-connector.go 0.00% 5 Missing ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 4 Missing ⚠️
...ces/mgmt/v1alpha1/connection-service/connection.go 0.00% 4 Missing ⚠️
...nternal/connect/interceptors/logger/interceptor.go 50.00% 1 Missing ⚠️
...r/internal/benthos/transformers/transform_float.go 80.00% 0 Missing and 1 partial ⚠️
...r/internal/benthos/transformers/transform_int64.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
+ Coverage   17.25%   17.69%   +0.44%     
==========================================
  Files         214      191      -23     
  Lines       45064    43104    -1960     
==========================================
- Hits         7777     7629     -148     
+ Misses      36322    34523    -1799     
+ Partials      965      952      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei changed the title updates code to not log invalid postgres urls that leak info Updates logging tags, transform float/int to use relative min/max Apr 20, 2024
@nickzelei nickzelei marked this pull request as ready for review April 20, 2024 23:35
@nickzelei nickzelei merged commit 6ceed2c into main Apr 20, 2024
19 checks passed
@nickzelei nickzelei deleted the nick/weekendbugs branch April 20, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant