-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates logging tags, transform float/int to use relative min/max #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickzelei
commented
Apr 20, 2024
•
edited
Loading
edited
- Updates code to not leak urls that are invalid on parse in logs
- Updates transform_float and transform_int to use relative min/max like they were intended to
- Adds new logging interceptor to add user information to the logs so that we can better track users in the system during debugging
- Updates the standard logging interceptor to attach the procedure to every request to more easily track logs per procedure type.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
+ Coverage 17.25% 17.69% +0.44%
==========================================
Files 214 191 -23
Lines 45064 43104 -1960
==========================================
- Hits 7777 7629 -148
+ Misses 36322 34523 -1799
+ Partials 965 952 -13 ☔ View full report in Codecov by Sentry. |
nickzelei
changed the title
updates code to not log invalid postgres urls that leak info
Updates logging tags, transform float/int to use relative min/max
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.