Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to have user annotations on generated Q&A #1705

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 8, 2024

Description

Extends HTTP interface to support annotations on QA from the user.
The goal is so that anyone training QA models with nucliadb (i.e: the LLM team at nuclia) have a way to manually annotate paragraphs / cancel QA pairs generated by the model under test.

How was this PR tested?

Integration tests

@lferran lferran requested a review from bloodbare January 8, 2024 12:03
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5174427) 82.12% compared to head (9c1d8e3) 82.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
- Coverage   82.12%   82.11%   -0.02%     
==========================================
  Files         334      334              
  Lines       19460    19446      -14     
==========================================
- Hits        15982    15968      -14     
  Misses       3478     3478              
Flag Coverage Δ
search 79.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from a team January 8, 2024 12:12
@jotare jotare merged commit 616f041 into main Jan 9, 2024
83 checks passed
@jotare jotare deleted the add-qa-annotations branch January 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants