Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 bucket create #1710

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix s3 bucket create #1710

merged 2 commits into from
Jan 9, 2024

Conversation

vangheem
Copy link
Contributor

@vangheem vangheem commented Jan 9, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (616f041) 82.15% compared to head (b36d9cd) 82.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         334      334           
  Lines       19489    19489           
=======================================
  Hits        16011    16011           
  Misses       3478     3478           
Flag Coverage Δ
ingest 69.25% <ø> (ø)
nucliadb 70.32% <ø> (+<0.01%) ⬆️
reader 79.02% <ø> (ø)
sdk 40.46% <ø> (ø)
search 79.24% <ø> (ø)
standalone 88.27% <ø> (ø)
train 63.76% <ø> (ø)
utils 81.25% <100.00%> (+<0.01%) ⬆️
writer 85.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem merged commit 269c9cc into main Jan 9, 2024
83 checks passed
@vangheem vangheem deleted the fix-s3-bucket-create branch January 9, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants