-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use read only transaction more on search #1726
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
+ Coverage 82.16% 82.19% +0.02%
==========================================
Files 335 336 +1
Lines 19803 19847 +44
==========================================
+ Hits 16271 16313 +42
- Misses 3532 3534 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Related ticket [sc-8127] |
This pull request has been linked to Shortcut Story #8127: refactor transaction context var on search. |
1998873
to
b8f9aea
Compare
aa3a399
to
6928e0e
Compare
42d7d52
to
98fbb28
Compare
45feb70
to
db171d4
Compare
Description
Even if we had the shared transaction logic in place, many code in the search endpoints was creating extra transactions.
This caused a drop in performance specially when using the PG driver for the maindb (Hybrid on-prem deployments!)
The improvement on the performance tests is around 2x:
On main
On the current branch
How was this PR tested?
Describe how you tested this PR.