Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send primary id on ListMembers grpc call #1727

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 15, 2024

Description

The final goal is to show this property in the ntool

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a90363e) 81.15% compared to head (366856d) 78.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   81.15%   78.81%   -2.35%     
==========================================
  Files         334      334              
  Lines       19550    19550              
==========================================
- Hits        15866    15408     -458     
- Misses       3684     4142     +458     
Flag Coverage Δ
ingest 69.10% <ø> (ø)
nucliadb 62.76% <ø> (-6.01%) ⬇️
reader 79.02% <ø> (ø)
search 79.09% <ø> (ø)
standalone 88.27% <ø> (ø)
utils 81.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from a team January 15, 2024 08:26
@lferran lferran force-pushed the add-primary-id-on-ntool-cluster-page branch from ad45bd9 to 366856d Compare January 15, 2024 15:24
@lferran lferran merged commit d487a11 into main Jan 15, 2024
80 of 81 checks passed
@lferran lferran deleted the add-primary-id-on-ntool-cluster-page branch January 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants