Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nucliadb docker print logs to stdout #1737

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Jan 18, 2024

Description

NucliaDB docker image uses file logs. While this is interesting if running nucliadb as a command, docker capture logs from stdout. With this change, docker logs <container> will show logs, while before one need to enter the container and read log files

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team January 18, 2024 10:57
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b7ab33) 82.19% compared to head (3d8807e) 82.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         335      335           
  Lines       19592    19592           
=======================================
  Hits        16104    16104           
  Misses       3488     3488           
Flag Coverage Δ
ingest 69.05% <ø> (ø)
nucliadb 70.33% <ø> (ø)
reader 79.41% <ø> (ø)
sdk 40.58% <ø> (ø)
train 63.71% <ø> (ø)
utils 81.25% <ø> (ø)
writer 85.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit b8c53e5 into main Jan 18, 2024
71 checks passed
@jotare jotare deleted the nucliadb-docker-logs-to-stdout branch January 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants