Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop replication when suspecting a partial shard #1744

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

hermeGarcia
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3f6c03) 82.20% compared to head (2006193) 82.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files         336      336           
  Lines       19609    19609           
=======================================
  Hits        16119    16119           
  Misses       3490     3490           
Flag Coverage Δ
ingest 69.05% <ø> (ø)
node-sidecar 95.39% <ø> (ø)
nucliadb 70.35% <ø> (ø)
reader 79.41% <ø> (ø)
sdk 40.58% <ø> (ø)
search 79.04% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.71% <ø> (ø)
utils 81.25% <ø> (ø)
writer 85.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hermeGarcia hermeGarcia merged commit f418b65 into main Jan 19, 2024
105 checks passed
@hermeGarcia hermeGarcia deleted the fail-for-partial-shards branch January 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants