Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics to resource cache #1774

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

javitonino
Copy link
Contributor

Description

Add some metrics to the cache from #1738

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4afd82) 82.18% compared to head (eb4907f) 82.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files         336      336           
  Lines       19852    19852           
=======================================
  Hits        16316    16316           
  Misses       3536     3536           
Flag Coverage Δ
ingest 69.04% <ø> (ø)
node-sidecar 95.39% <ø> (ø)
nucliadb 70.35% <ø> (ø)
reader 79.82% <ø> (ø)
sdk 40.64% <ø> (ø)
search 76.75% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.62% <ø> (ø)
writer 85.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hermeGarcia hermeGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@javitonino javitonino merged commit f930a08 into main Jan 26, 2024
103 checks passed
@javitonino javitonino deleted the resource_cache_metrics branch January 26, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants