Misc improvements #1802
Merged
Misc improvements #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
- Coverage 82.10% 81.55% -0.56%
==========================================
Files 338 338
Lines 19910 20255 +345
==========================================
+ Hits 16348 16518 +170
- Misses 3562 3737 +175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
With relations v2, fuzzy results are returned, so this situations can occur often
jotare
force-pushed
the
misc-improvements
branch
from
b903525
to
b923863
Compare
lferran
reviewed
Feb 8, 2024
lferran
reviewed
Feb 8, 2024
| scope.set_extra("relation", relation) | ||
| errors.capture_message(error_msg, "error") | ||
| logger.warning( | ||
| "Relation search is returning an edge unrelated with queried entities" |
There was a problem hiding this comment.
can you log at least which is the entity/relation to blame?
Also the extra={"kbid": kbid}
There was a problem hiding this comment.
kbid is not available. I'll add some extras though
lferran
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mix of diverse improvements:
How was this PR tested?
Describe how you tested this PR.