Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary improvements #1809

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Summary improvements #1809

merged 6 commits into from
Feb 7, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Feb 7, 2024

Description

  • Richer openapi docs
  • Handle both slugs and uuids for resources
  • Remove feature flag check

How was this PR tested?

Integration tests

@lferran
Copy link
Contributor Author

lferran commented Feb 7, 2024

[sc-8728]

Copy link

This pull request has been linked to Shortcut Story #8728: Add slug parameter to /summarize.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b170d0f) 82.16% compared to head (d9dfe6a) 82.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1809   +/-   ##
=======================================
  Coverage   82.16%   82.17%           
=======================================
  Files         338      338           
  Lines       19738    19744    +6     
=======================================
+ Hits        16218    16224    +6     
  Misses       3520     3520           
Flag Coverage Δ
ingest 70.06% <ø> (ø)
nucliadb 70.28% <100.00%> (+0.01%) ⬆️
reader 80.72% <ø> (ø)
sdk 40.58% <ø> (ø)
search 74.44% <13.33%> (-0.32%) ⬇️
standalone 87.79% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.62% <ø> (-0.01%) ⬇️
writer 85.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from a team February 7, 2024 15:07
@lferran lferran merged commit c021ae3 into main Feb 7, 2024
83 checks passed
@lferran lferran deleted the summary-improvements branch February 7, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants