Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioned internal predict api #1814

Merged
merged 2 commits into from
Feb 9, 2024
Merged

versioned internal predict api #1814

merged 2 commits into from
Feb 9, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Feb 9, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fbe856) 82.18% compared to head (9f3fb96) 82.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   82.18%   82.19%           
=======================================
  Files         338      338           
  Lines       19724    19723    -1     
=======================================
  Hits        16211    16211           
+ Misses       3513     3512    -1     
Flag Coverage Δ
ingest 70.06% <ø> (+0.02%) ⬆️
sdk 40.58% <ø> (ø)
utils 81.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested review from bloodbare and a team February 9, 2024 06:53
@lferran lferran merged commit 06f2ceb into main Feb 9, 2024
80 of 81 checks passed
@lferran lferran deleted the adapt-to-new-internal-predict branch February 9, 2024 07:26
lferran added a commit that referenced this pull request Feb 9, 2024
* versioned internal predict api

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants