-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCS delete bucket status code #1835
Fix GCS delete bucket status code #1835
Conversation
This pull request has been linked to Shortcut Story #8700: Fix purge command errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
+ Coverage 82.10% 84.25% +2.14%
==========================================
Files 338 328 -10
Lines 19708 18897 -811
==========================================
- Hits 16181 15921 -260
+ Misses 3527 2976 -551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
Can you make sure we at least get a sentry event if the response status is not any of those that we handle here?
Also, can you check that this is also fixed on the writer tus gcs driver?
1865e80
to
df32fb3
Compare
Description
DELETE a bucket returns a 204 in GCS, not a 200
How was this PR tested?
Describe how you tested this PR.