Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCS delete bucket status code #1835

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Feb 14, 2024

Description

DELETE a bucket returns a 204 in GCS, not a 200

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team February 14, 2024 10:08
Copy link

This pull request has been linked to Shortcut Story #8700: Fix purge command errors.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d6bbc4) 82.10% compared to head (df32fb3) 84.25%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   82.10%   84.25%   +2.14%     
==========================================
  Files         338      328      -10     
  Lines       19708    18897     -811     
==========================================
- Hits        16181    15921     -260     
+ Misses       3527     2976     -551     
Flag Coverage Δ
ingest 69.88% <ø> (ø)
sdk 87.85% <ø> (+47.20%) ⬆️
utils 81.76% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lferran lferran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!
Can you make sure we at least get a sentry event if the response status is not any of those that we handle here?

Also, can you check that this is also fixed on the writer tus gcs driver?

@jotare jotare force-pushed the joanantoniriera4168/sc-8700/fix-purge-command-errors-1 branch from 1865e80 to df32fb3 Compare February 14, 2024 16:27
@jotare jotare merged commit 44a970a into main Feb 15, 2024
79 checks passed
@jotare jotare deleted the joanantoniriera4168/sc-8700/fix-purge-command-errors-1 branch February 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants