Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error code parsing for AWS S3 responses #1837

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Feb 14, 2024

Description

Error status is sometimes a number and sometimes a string with a special code. I've created a simple function to parse it and return a number always. More mappings can be added if needed

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team February 14, 2024 16:30
Copy link

This pull request has been linked to Shortcut Story #8700: Fix purge command errors.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (44a970a) 84.24% compared to head (41e6d79) 84.25%.

Files Patch % Lines
nucliadb_utils/nucliadb_utils/storages/s3.py 63.63% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage   84.24%   84.25%           
=======================================
  Files         328      328           
  Lines       18892    18908   +16     
=======================================
+ Hits        15916    15930   +14     
- Misses       2976     2978    +2     
Flag Coverage Δ
ingest 69.88% <ø> (ø)
sdk 87.85% <ø> (ø)
utils 81.80% <65.21%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare force-pushed the joanantoniriera4168/sc-8700/fix-purge-command-errors-2 branch from e2bea92 to 282e068 Compare February 15, 2024 08:59
@jotare jotare merged commit e590bb4 into main Feb 15, 2024
79 checks passed
@jotare jotare deleted the joanantoniriera4168/sc-8700/fix-purge-command-errors-2 branch February 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants