Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model metadata is still received via grpc for hosted #1849

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Feb 19, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team February 19, 2024 13:04
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (513ac01) 84.28% compared to head (a5badec) 84.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1849   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         328      328           
  Lines       18856    18875   +19     
=======================================
+ Hits        15892    15909   +17     
- Misses       2964     2966    +2     
Flag Coverage Δ
ingest 70.27% <100.00%> (+0.09%) ⬆️
sdk 87.85% <ø> (ø)
utils 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 0d1018f into main Feb 19, 2024
81 checks passed
@lferran lferran deleted the kb-creation-logic-fixes branch February 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants