Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce max max shard size #1857

Merged
merged 3 commits into from
Feb 20, 2024
Merged

reduce max max shard size #1857

merged 3 commits into from
Feb 20, 2024

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (963e927) 84.28% compared to head (5381c3c) 84.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1857   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         328      328           
  Lines       18865    18865           
=======================================
  Hits        15900    15900           
  Misses       2965     2965           
Flag Coverage Δ
ingest 70.27% <ø> (ø)
sdk 87.85% <ø> (ø)
utils 81.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem merged commit 1eda302 into main Feb 20, 2024
79 checks passed
@vangheem vangheem deleted the reduce-default-max-shard-settintgs branch February 20, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants