Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shards protobuf to represent multiple writable shards #1927

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Mar 12, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

This pull request has been linked to Shortcut Story #9268: Update Shards protobuf to represent multiple active shards.

@jotare jotare marked this pull request as draft March 12, 2024 10:32
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.97%. Comparing base (31740e4) to head (6efc8a4).

Files Patch % Lines
nucliadb/nucliadb/ingest/consumer/shard_creator.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1927   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files         329      329           
  Lines       18713    18681   -32     
=======================================
- Hits        15714    15688   -26     
+ Misses       2999     2993    -6     
Flag Coverage Δ
ingest 68.73% <83.33%> (+<0.01%) ⬆️
sdk 87.85% <ø> (ø)
utils 82.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare marked this pull request as ready for review March 12, 2024 15:02
@jotare jotare force-pushed the joanantoniriera4168/sc-9268/update-shards-protobuf-to-represent-multiple branch from f2f2798 to 3a21a3a Compare March 12, 2024 16:28
@jotare jotare force-pushed the joanantoniriera4168/sc-9268/update-shards-protobuf-to-represent-multiple branch from 3a21a3a to 5c42cc6 Compare March 13, 2024 12:11
@jotare jotare force-pushed the joanantoniriera4168/sc-9268/update-shards-protobuf-to-represent-multiple branch from f785160 to a42751b Compare March 14, 2024 08:07
@jotare jotare force-pushed the joanantoniriera4168/sc-9268/update-shards-protobuf-to-represent-multiple branch from a42751b to 9547e79 Compare March 19, 2024 10:21
@jotare jotare merged commit 4915765 into main Mar 19, 2024
84 checks passed
@jotare jotare deleted the joanantoniriera4168/sc-9268/update-shards-protobuf-to-represent-multiple branch March 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants