-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table processing #1949
Table processing #1949
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
- Coverage 83.82% 83.78% -0.05%
==========================================
Files 326 326
Lines 17786 17750 -36
==========================================
- Hits 14910 14872 -38
- Misses 2876 2878 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* query parsing info available in chat * notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 1005 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
872 | 1 | 132 | 0 |
Click to see the invalid file list
- nucliadb/nucliadb/search/search/chat/images.py
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's all right but I feel you should add some tests to validate functionality and simplify future maintenance
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.