Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table processing #1949

Merged
merged 38 commits into from
Mar 27, 2024
Merged

Table processing #1949

merged 38 commits into from
Mar 27, 2024

Conversation

bloodbare
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.78%. Comparing base (222974c) to head (4fafc8f).
Report is 2 commits behind head on main.

Files Patch % Lines
nucliadb_utils/nucliadb_utils/asyncio_utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
- Coverage   83.82%   83.78%   -0.05%     
==========================================
  Files         326      326              
  Lines       17786    17750      -36     
==========================================
- Hits        14910    14872      -38     
- Misses       2876     2878       +2     
Flag Coverage Δ
ingest 68.50% <100.00%> (+<0.01%) ⬆️
sdk 87.85% <ø> (ø)
utils 81.66% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 1005 files.

Valid Invalid Ignored Fixed
872 1 132 0
Click to see the invalid file list
  • nucliadb/nucliadb/search/search/chat/images.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bloodbare bloodbare marked this pull request as ready for review March 18, 2024 08:46
Copy link
Contributor

@jotare jotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's all right but I feel you should add some tests to validate functionality and simplify future maintenance

nucliadb_models/nucliadb_models/search.py Outdated Show resolved Hide resolved
@bloodbare bloodbare changed the title Table processing init Table processing Mar 26, 2024
@bloodbare bloodbare merged commit c5aaa81 into main Mar 27, 2024
83 checks passed
@bloodbare bloodbare deleted the table_processing branch March 27, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants