Zeroize sensitive materials #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
reviewed
May 8, 2023
fjarri
reviewed
May 10, 2023
fjarri
reviewed
May 10, 2023
fjarri
reviewed
May 10, 2023
| @@ -1,717 +0,0 @@ | |||
| use std::collections::BTreeMap; | |||
There was a problem hiding this comment.
I don't follow the development in this repo, but I'm just curious, how does this removal fit with the topic of the PR?
There was a problem hiding this comment.
It doesn't fit here, it's just something I noticed. I admit it should be a separate change to avoid any confusion with this PR.
Would you be interested in following the development here or reviewing PRs in the future?
There was a problem hiding this comment.
I would, but I cannot guarantee that I will be available.
fjarri
reviewed
May 10, 2023
fjarri
reviewed
May 10, 2023
fjarri
reviewed
May 10, 2023
fjarri
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeroizeall sensitive material #61phi, or the secret polynomial created by a DKG dealerSharedSecret, acrossferveoandtpkecrates, in any shape or formChaCha20Poly1305instance intpkecreate, resulting from usage of the shared secretPrivateKeyShareintpkeplaintexttpke