Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update byte serialization in bindings #109

Merged
merged 8 commits into from
May 8, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented May 5, 2023

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #109 (6a74f83) into main (85fe85a) will decrease coverage by 0.17%.
The diff coverage is 53.06%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   79.67%   79.50%   -0.17%     
==========================================
  Files          23       23              
  Lines        4698     4708      +10     
==========================================
  Hits         3743     3743              
- Misses        955      965      +10     
Impacted Files Coverage Δ
ferveo-common/src/keypair.rs 73.97% <ø> (+2.91%) ⬆️
ferveo-wasm/src/lib.rs 0.29% <0.00%> (-0.01%) ⬇️
ferveo-python/src/lib.rs 63.83% <19.04%> (-1.70%) ⬇️
ferveo/src/api.rs 91.27% <100.00%> (ø)
ferveo/src/dkg.rs 95.49% <100.00%> (ø)
ferveo/src/lib.rs 97.30% <100.00%> (ø)

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review May 8, 2023 07:43
@piotr-roslaniec
Copy link
Author

@derekpierre Are there any other places where removing serialization overhead (u8) matters?

@derekpierre
Copy link
Member

derekpierre commented May 8, 2023

@derekpierre Are there any other places where removing serialization overhead (u8) matters?

  • I thought I remembered you mentioned potentially changing the serialization for Transcripts as well. Was that done already/still planned to be done? Reducing the size of anything added to the Coordinator helps to keep gas prices down.
  • Did you add the serialized_size() method after 0.1.10 was published? I don't see it.

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@piotr-roslaniec
Copy link
Author

@derekpierre Transcript has a variable length (depending on the size of the ritual) and so I'm unable to make any improvements there.
I just published ferveo-py@0.1.11 which exposed serialized_size.

@derekpierre
Copy link
Member

@derekpierre Transcript has a variable length (depending on the size of the ritual) and so I'm unable to make any improvements there. I just published ferveo-py@0.1.11 which exposed serialized_size.

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants