-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update byte serialization in bindings #109
Conversation
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 79.67% 79.50% -0.17%
==========================================
Files 23 23
Lines 4698 4708 +10
==========================================
Hits 3743 3743
- Misses 955 965 +10
|
@derekpierre Are there any other places where removing serialization overhead ( |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
@derekpierre |
Great. Thanks! |
50dca8e
to
639590c
Compare
arkworks
primitives #101dkg.final_key
todkg.public_key
in Python & WASM bindingsDkgPublicKey
is serialized to bytes without extrau8
denotingVec<u8>
length, using aGenericArray
insteadDkgPublicKey.serialized_size