Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose language bindings as features from ferveo crate #118

Merged
merged 15 commits into from
Jun 2, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented May 22, 2023

Based on #114 - Please review it first.

Type of PR:

  • Refactor

Required reviews:

  • 1

What this does:

  • Performs steps necessary for integration with nucypher-core as described in Prepare for integration with nucypher-core #112
  • Language bindings are now exposed from ferveo crate as bindings_wasm and bindings_python features, similarly how rust-umbral does it

Issues fixed/closed:

Why it's needed:

  • To use ferveo types directly in nucypher-core

Notes for reviewers:

  • This a refactor and reconfiguration of existing crates
  • No functional changes

@codecov-commenter
Copy link

Codecov Report

Merging #118 (591c05e) into main (d246995) will decrease coverage by 1.95%.
The diff coverage is 34.05%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   79.45%   77.50%   -1.95%     
==========================================
  Files          23       24       +1     
  Lines        4809     4935     +126     
==========================================
+ Hits         3821     3825       +4     
- Misses        988     1110     +122     
Impacted Files Coverage Δ
ferveo-common/src/lib.rs 100.00% <ø> (ø)
ferveo/src/bindings_wasm.rs 0.00% <0.00%> (ø)
ferveo/src/pvss.rs 91.68% <ø> (ø)
ferveo/src/utils.rs 94.73% <ø> (ø)
ferveo-python/src/lib.rs 1.28% <1.75%> (-62.89%) ⬇️
ferveo/src/bindings_python.rs 59.36% <59.36%> (ø)
ferveo-wasm/src/lib.rs 100.00% <100.00%> (+99.72%) ⬆️
ferveo/src/dkg.rs 95.49% <100.00%> (ø)
ferveo/src/lib.rs 97.40% <100.00%> (ø)
tpke/src/ciphertext.rs 89.41% <100.00%> (-0.06%) ⬇️
... and 1 more

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review May 22, 2023 13:48
@piotr-roslaniec piotr-roslaniec self-assigned this May 22, 2023
@piotr-roslaniec piotr-roslaniec merged commit 11d6cea into main Jun 2, 2023
@piotr-roslaniec piotr-roslaniec deleted the expose-bindings-from-main-crate branch June 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
2 participants