forked from anoma/ferveo
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for ACP, ThresholdMessageKit work in nucypher-core
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused Ciphertext.construct_tag_hash() * Refactor Ciphertext.check() to take the functionality of check_ciphertext_validity() function
derekpierre
changed the title
[WIP] Changes needed for ACP, ThresholdMessageKit work
[WIP] Changes needed for ACP, ThresholdMessageKit work in Aug 16, 2023
nucypher-core
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 77.96% 77.88% -0.09%
==========================================
Files 23 23
Lines 4979 5033 +54
==========================================
+ Hits 3882 3920 +38
- Misses 1097 1113 +16
|
derekpierre
requested review from
jMyles,
KPrasch,
cygnusv,
theref,
manumonti and
piotr-roslaniec
August 22, 2023 20:31
derekpierre
changed the title
[WIP] Changes needed for ACP, ThresholdMessageKit work in
Changes needed for ACP, ThresholdMessageKit work in Aug 22, 2023
nucypher-core
nucypher-core
piotr-roslaniec
approved these changes
Aug 23, 2023
KPrasch
approved these changes
Aug 23, 2023
cygnusv
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Based over #155 (which is based over #149 )
Related to:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: