forked from anoma/ferveo
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ferveo
and tpke
crates
#27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2023
6 tasks
Postponing review until implementing blinding of key shares |
piotr-roslaniec
force-pushed
the
dkg-pvss-flow
branch
from
January 18, 2023 16:42
d51000a
to
c5634a9
Compare
piotr-roslaniec
commented
Jan 19, 2023
piotr-roslaniec
force-pushed
the
dkg-pvss-flow
branch
from
January 20, 2023 13:42
339d1f0
to
57c9763
Compare
theref
approved these changes
Jan 23, 2023
ferveo/benches/benchmarks/pvdkg.rs
Outdated
@@ -66,16 +63,16 @@ pub fn setup_dkg( | |||
) -> PubliclyVerifiableDkg<EllipticCurve> { | |||
let keypairs = gen_keypairs(num); | |||
let validators = gen_validators(&keypairs); | |||
let me = validators.validators[validator].clone(); | |||
let me = validators[validator].clone(); | |||
PubliclyVerifiableDkg::new( | |||
validators, | |||
Params { | |||
tau: 0, | |||
security_threshold: 300 / 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is 300 coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's shares_num
, from the line below. Should be reused here.
piotr-roslaniec
commented
Jan 23, 2023
piotr-roslaniec
commented
Jan 23, 2023
piotr-roslaniec
commented
Jan 23, 2023
piotr-roslaniec
force-pushed
the
dkg-pvss-flow
branch
from
January 23, 2023 17:12
fb7c5a2
to
bacea0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ferveo
andtpke
cratesferveo/src/lib.rs
that you could start with. They both perform simple threshold decryption variant fromtpke
crate.test_dkg_simple_decryption_variant_single_validator
- performs tDec using a single validator (1-of-1 scheme). Serves as a sanity check for an edge case.test_dkg_simple_decryption_variant
performs tDec using a 3-of-4 schemesetup_dealt_dkg_with_n_validators
replacessetup_simple
fromtpke
crate tests. The remainder of theferveo
tests is an adoption oftpke
crate tests.tpke