Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin fixing TODO's in codebase #54

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Begin fixing TODO's in codebase #54

merged 2 commits into from
Feb 13, 2023

Conversation

theref
Copy link

@theref theref commented Jan 30, 2023

No description provided.

@piotr-roslaniec
Copy link

@theref I just created this issue: #55
I think we would benefit from discussing it with @cygnusv since it may alter our DKG design.

@piotr-roslaniec
Copy link

piotr-roslaniec commented Jan 31, 2023 •
edited
Loading

Some of the TODOs in bindings and APIs are going to be replaced with proper code/other TODOs as we are working on the new version of bindings.

piotr-roslaniec
piotr-roslaniec approved these changes Feb 6, 2023
View reviewed changes
Copy link

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please feel free to merge when ready.

@theref theref merged commit 6022f00 into nucypher:main Feb 13, 2023
@theref theref deleted the TODO branch February 13, 2023 09:25
@piotr-roslaniec piotr-roslaniec mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-roslaniec piotr-roslaniec piotr-roslaniec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v7.0.0 (TACo)
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theref @piotr-roslaniec