forked from anoma/ferveo
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a validator ordering issue with PVSS & DKG instances #95
Merged
piotr-roslaniec
merged 9 commits into
nucypher:main
from
piotr-roslaniec:implicit-ordering
Apr 24, 2023
Merged
Fix a validator ordering issue with PVSS & DKG instances #95
piotr-roslaniec
merged 9 commits into
nucypher:main
from
piotr-roslaniec:implicit-ordering
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
commented
Apr 20, 2023
•
edited
Loading
edited
- Browse the commits one by one to follow the developments of this story
- Replaces implicit ordering with explicit ordering and validity checks
- Changes how the ordering of shares and validators is tracked within DKG
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 81.78% 80.65% -1.13%
==========================================
Files 25 23 -2
Lines 3975 4157 +182
==========================================
+ Hits 3251 3353 +102
- Misses 724 804 +80
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piotr-roslaniec
changed the title
Document an ordering issue with PVSS & DKG instances
Fix a validator ordering issue with PVSS & DKG instances
Apr 20, 2023
piotr-roslaniec
force-pushed
the
implicit-ordering
branch
from
April 24, 2023 10:48
d09af8c
to
6bb4746
Compare
piotr-roslaniec
force-pushed
the
implicit-ordering
branch
from
April 24, 2023 13:37
6ab8e5e
to
2d96a30
Compare
piotr-roslaniec
force-pushed
the
implicit-ordering
branch
from
April 24, 2023 14:47
f1c2ff7
to
a23500c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.