Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CircleCI configuration #233

Merged
merged 4 commits into from
Dec 15, 2018
Merged

Updated CircleCI configuration #233

merged 4 commits into from
Dec 15, 2018

Conversation

cygnusv
Copy link
Member

@cygnusv cygnusv commented Dec 12, 2018

@cygnusv cygnusv changed the title [WIP] Updated CircleCI configuration Updated CircleCI configuration Dec 13, 2018
@cygnusv cygnusv requested a review from tuxxy December 13, 2018 15:17
bundle_dependencies-35:
<<: *python_35_base
commands:
pipenv_install:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the fancy new circleCI 2.1 features if anyone else is looking

paths:
- "~/.local/share/virtualenvs/"
key: v2-deps-{{ .Environment.CIRCLE_WORKFLOW_ID }}-{{ checksum "Pipfile.lock" }}-py37
- pipenv_install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ... and it's usage

Copy link
Member

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to test it live to feel confident our publication markup will integrate with the new commands feature ~ Looks Good!

Copy link
Contributor

@tuxxy tuxxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧

@tuxxy tuxxy merged commit 6c20faf into nucypher:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants