Add Initial SIWE support to taco-auth for Demo
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
derekpierre
changed the title
taco-authtaco-auth
piotr-roslaniec
force-pushed
the
auth-siwe
branch
from
e2d658f
to
527f9d6
Compare
Co-authored-by: Piotr Roslaniec <p.roslaniec@gmail.com>
Modify some default values used for creating SIWE message, including use a random nonce.
…used tests to fail. Co-authored-by: Manuel Montenegro <manuel@nucypher.com>
Fix the URI used for EIP4361 message to be properly formed - it caused an invalid SIWE message to be created.
…are invalid for SIWE.
Run linter.
…61 to be more accurate and in line with EIP712 auth signature call. This can perhaps be an interface/base class method in the future. Run linter.
derekpierre
changed the title
taco-authtaco-auth for Demo
derekpierre
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
🎸 - Good to merge this checkpoint of the code which was used for the Ceramic demo. It will be merged into the broader EPIC #527 where additional changes will be made based on feedback/discussions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
This was an initial implementation of SIWE support used for the Ceramic demo. Post-demo, the implementation will be modified based on updated discussions/realizations, but these can be done in a separate PR. This is a good checkpoint to merge since we are simply merging into an EPIC branch and not directly into
main.Issues fixed/closed:
Why it's needed:
Notes for reviewers: